D5402: always close the downloaded file after downloading
This revision was automatically updated to reflect the committed changes. Closed by commit R304:925ec8a17ffb: always close the downloaded file after downloading (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5402?vs=13331=13344 REVISION DETAIL https://phabricator.kde.org/D5402 AFFECTED FILES src/core/jobs/httpworker.cpp To: mart, #plasma, leinir, bshah Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5402: always close the downloaded file after downloading
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved. REPOSITORY R304 KNewStuff BRANCH phab/closeFile REVISION DETAIL https://phabricator.kde.org/D5402 To: mart, #plasma, leinir, bshah Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5402: always close the downloaded file after downloading
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY sometimes the downloaded file isn't correctly flushed to disk, causing corrupted zip files, especially if they come from github that does a redirect. Unconditionally closing it fixes the problem TEST PLAN downloaded the unity8 gtk3 theme that comes from github and is fine, other files coming directly from store.kde.org are fine as well REPOSITORY R304 KNewStuff BRANCH phab/closeFile REVISION DETAIL https://phabricator.kde.org/D5402 AFFECTED FILES src/core/jobs/httpworker.cpp To: mart, #plasma, leinir, bshah Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
