D5413: makes KArchive be optional and do not build extractors needing it

2017-04-16 Thread Matthieu Gallien 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:599e9b6489fe: makes KArchive be optional and do not build 
extractors needing it (authored by mgallien).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5413?vs=13496=13507#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5413?vs=13496=13507

REVISION DETAIL
  https://phabricator.kde.org/D5413

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/extractors/CMakeLists.txt

To: mgallien, kfunk, dfaure
Cc: kfunk, heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-16 Thread David Faure 
dfaure accepted this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5413

To: mgallien, kfunk, dfaure
Cc: kfunk, heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-15 Thread Matthieu Gallien 
mgallien updated this revision to Diff 13496.
mgallien added a comment.


  added a set_package_properties for KF5Archive

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5413?vs=13359=13496

BRANCH
  karchive_optional

REVISION DETAIL
  https://phabricator.kde.org/D5413

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/extractors/CMakeLists.txt

To: mgallien, kfunk
Cc: kfunk, heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-15 Thread Kevin Funk 
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  +1

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5413

To: mgallien, kfunk
Cc: kfunk, heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-15 Thread Heiko Becker 
heikobecker added a comment.


  In https://phabricator.kde.org/D5413#102273, @dfaure wrote:
  
  > Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the 
user is told about the optional deps they're missing?
  >  Not sure if that works for KF5 components.
  
  
  No, OPTIONAL is the default. But I'd say that using 
set_package_properties(...) including a meaningful "DESCRIPTION" and "PURPOSE" 
(e.g. like it's done for the other optional deps) is much nicer to packagers 
and others who try to build kfilemetadata.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5413

To: mgallien
Cc: heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-15 Thread David Faure 
dfaure added a comment.


  Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the 
user is told about the optional deps they're missing?
  Not sure if that works for KF5 components.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5413

To: mgallien
Cc: dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-12 Thread Matthieu Gallien 
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Let Karchive be an optional build dependency of KFileMetaData

TEST PLAN
  Still build with or without KArchive

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5413

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/extractors/CMakeLists.txt

To: mgallien
Cc: #frameworks