This revision was automatically updated to reflect the committed changes.
Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning
(authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5773?vs=1=14445
davidedmundson added a comment.
don't keep [WIP} in the title though :)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D5773
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D5773
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson,
mart updated this revision to Diff 1.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- remove duplication
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5773?vs=14438=1
davidedmundson added inline comments.
INLINE COMMENTS
> qmenu.cpp:117
> +m_menu->windowHandle()->setTransientParent(item->window());
> +}
> }
we always do this in ::open()
so why have this chunk?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
mart updated this revision to Diff 14438.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- more aggressive reparenting in open()
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson added inline comments.
INLINE COMMENTS
> qmenu.cpp:322-327
> +if (parentItem) {
> +//create the QWindow
> +m_menu->winId();
> +m_menu->windowHandle()->setTransientParent(parentItem->window());
> +}
> }
why not just also do
mart updated this revision to Diff 14311.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
apply workaround when we have only parentItem
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
looks sensible.
Is this only needed for a specific version of Qt? In either case can you
check on the Qt 5.7 machine.
INLINE COMMENTS
> qmenu.cpp:112
> +
> +QQuickItem *item = qobject_cast(m_visualParent.data());
> +if (item) {
there's a
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
this ensure two things:
- submenus have the main menu as transientParent
- the visualParent window() is used as
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
11 matches
Mail list logo
