D7127: ignore spurious resize events to empty sizes

cfeck added a comment. The commit still says "size != oldSize". Is this correct? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: cfeck, davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot,

D7127: ignore spurious resize events to empty sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c27df529d80: ignore spurious resize events to empty sizes (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7127: ignore spurious resize events to empty sizes

mart updated this revision to Diff 17832. mart added a comment. more comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17712=17832 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES

D7127: ignore spurious resize events to empty sizes

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks! add some code comments. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 To: mart,

D7127: ignore spurious resize events to empty sizes

mart added a comment. finally figured out where this event is generated: it's a spontaneous event generated in qguiapplication.cpp QGuiApplicationPrivate::processWindowScreenChangedEvent around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent gce(window,

D7127: ignore spurious resize events to empty sizes

mart marked an inline comment as done. mart added a comment. not sure how to proceed in debugging this, as all i have is a resize event handler being called, which a backtrace there is useless to figure out who is resizing it REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D7127: ignore spurious resize events to empty sizes

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > on multiscreen systems, the notification dialog gets resized to 0x0 > by someone else (either kwin, notification applet or Qt code) So which is it?

D7127: ignore spurious resize events to empty sizes

mart updated this revision to Diff 17712. mart added a comment. - fix check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17704=17712 BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES

D7127: ignore spurious resize events to empty sizes

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > broulik wrote in dialog.cpp:1045 > So it will never update its size? Shouldn't it be size == oldSize? ouch, sure, sorry :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D7127: ignore spurious resize events to empty sizes

broulik added inline comments. INLINE COMMENTS > dialog.cpp:1045 > > +if (re->size().isEmpty() || re->size() != re->oldSize()) { > +return; So it will never update its size? Shouldn't it be size == oldSize? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL