D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
This revision was automatically updated to reflect the committed changes. Closed by commit R252:7524bf1535b4: Fix accepting dialogs with ctrl+return when buttons are renamed (authored by apol). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7196?vs=17862&id=17921 REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks, dfaure
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 To: apol, #frameworks, dfaure
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
apol updated this revision to Diff 17862. apol added a comment. Make sure there's such a button REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7196?vs=17860&id=17862 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY QAbstractButton::setText will call setShortcut(mnemonic), making this little hack unusable. This patch puts the shortcut into a separate object. TEST PLAN Improved the test to reproduce the issue I had Now we can use it with KDE Connect send reply dialogs REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks
