aacid closed this revision.
aacid added a comment.
Seems you commited this but forgot to close this?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kossebau, aacid, kfunk, #frameworks, #build_system
dfaure added a comment.
Patch for more docu: https://phabricator.kde.org/D7612
BTW CMAKE_LIBRARY_OUTPUT_DIRECTORY is not undocumented, it's part of the
cmake documentation:
Where to put all the :ref:`LIBRARY `
target files when built.
This variable is used to initializ
kossebau reopened this revision.
kossebau added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KDECMakeSettings.cmake:46-47
> +#
> +# When find_package(ECM 5.38) or higher is called, this also selects
> +# a layout for the build dir that helps running executab
dfaure added a comment.
Ooops, sorry. I had heavily tested ... a somewhat different version of the
patch :(
Thanks for the fixes.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: aacid, kfunk, #frameworks, #bui
cgiboudeaux added a comment.
In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote:
> Fixed with
https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498
(+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40)
REPOSITORY
R240 Ext
cgiboudeaux added a comment.
Fixed with
https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: aacid, kfunk, #frameworks, #build_system
aacid added a comment.
You broke all the builds
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: aacid, kfunk, #frameworks, #build_system
dfaure closed this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk accepted this revision.
kfunk added a comment.
I like the initiative, +1
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kfunk, #frameworks, #build_system
cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux
Cc: #frameworks, #build_system
dfaure created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
For compatibility reasons, this is only enabled when projects
upgrade their find_package(ECM) line to request a version >= 5.38.
A little bit like cmake policies: just upgrading EC
11 matches
Mail list logo