D7243: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop

2017-09-10 Thread David Faure 
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:9990eb0518e5: kpackage: bundle a copy of 
servicetypes/kpackage-generic.desktop (authored by dfaure).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7243?vs=17988&id=19363

REVISION DETAIL
  https://phabricator.kde.org/D7243

AFFECTED FILES
  autotests/data/testpackagesdep/metadata.json
  autotests/mockdepresolver/main.cpp
  src/kpackage/CMakeLists.txt
  src/kpackage/kpackage.qrc
  src/kpackage/package.cpp
  src/kpackage/private/packagejobthread.cpp

To: dfaure, mart
Cc: #frameworks

D7243: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop

2017-09-10 Thread David Faure 
dfaure added a comment.


  I'll take silence as approval, this should be non-controversial...

REVISION DETAIL
  https://phabricator.kde.org/D7243

To: dfaure, mart
Cc: #frameworks

D7243: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop

2017-08-10 Thread David Faure 
dfaure created this revision.

REVISION SUMMARY
  This allows to remove the dependency on the installed file, fixing
  "make test" in kpackage before installing it.
  
  I extended the unittest to have a list of deps, but it's really in a
  .desktop file that it would matter for checking that the servicetype
  is correctly found; didn't find a unittest for that though
  (both a desktop file and dependencies).
  
  [We could also just get rid of the servicetype desktop file being passed
  to KPluginMetadata, AFAICS, given that its properties are just strings
  and dependencies are looked up explicitly as a stringlist - but I guess
  we want to keep it in case there are more properties in the future]

TEST PLAN
  make uninstall ; ctest .

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7243

AFFECTED FILES
  autotests/data/testpackagesdep/metadata.json
  autotests/mockdepresolver/main.cpp
  src/kpackage/CMakeLists.txt
  src/kpackage/kpackage.qrc
  src/kpackage/package.cpp
  src/kpackage/private/packagejobthread.cpp

To: dfaure, mart
Cc: #frameworks