D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2018-04-21 Thread Nathaniel Graham 
ngraham updated this revision to Diff 32762.
ngraham added a comment.


  Attempt so far unsuccessfully to use statx directly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7423?vs=21871=32762

BRANCH
  arcpatch-D7423

REVISION DETAIL
  https://phabricator.kde.org/D7423

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.cpp

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: meven, ltoscano, #frameworks, michaelh, bruns

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread David Faure 
dfaure added a comment.


  Well, this hasn't been tested, has it?
  
  AFAIU this requires calling `statx(..., AT_SYMLINK_NOFOLLOW, ...)` instead of 
`lstat`, on systems where `statx` is available.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread Nathaniel Graham 
ngraham added a comment.


  In https://phabricator.kde.org/D7423#174599, @dfaure wrote:
  
  > One of us is missing something here.
  
  
  I'm sure it's me. :-)
  If this approach doesn't work, would you be able to offer some pointers 
regarding a better method of implementing it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread David Faure 
dfaure added a comment.


  In https://phabricator.kde.org/D7423#137952, @ngraham wrote:
  
  > This patch doesn't actually directly use statx(); it uses the existing 
approach, which goes through QFile, which is used to populate the statbuf 
object that we query.
  
  
  Can you show me where this code uses QFile to populate the statbuf object? 
One of us is missing something here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> file.cpp:783
>  
>  if (QT_LSTAT(path.data(), ) == 0)  {
>  

... but we fill `buff` using `lstat()`, not using QFile, so it doesn't matter 
what QFile does.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread Nathaniel Graham 
ngraham added a comment.


  Unless I'm misunderstanding everything, birthTime_ is only set to a nonzero 
value as of 
https://github.com/qt/qtbase/commit/d3393ce25833c0afd7f0fa6b85fd6f3bd7ad520a#diff-e061e747264146cf47a86b371e512348R363,
 which only made it into Qt 5.10 and was not backported to 5.9. 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-12-02 Thread David Faure 
dfaure added a comment.


  I don't get it. Which parts of this commit depend upon Qt 5.10? I only see 
buff.birthTime_ being used.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-11-04 Thread Nathaniel Graham 
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-11-04 Thread Nathaniel Graham 
ngraham updated this revision to Diff 21871.
ngraham added a comment.


  Improve comment for clarity

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7423?vs=18418=21871

BRANCH
  arcpatch-D7423

REVISION DETAIL
  https://phabricator.kde.org/D7423

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-08-22 Thread Nathaniel Graham 
ngraham added a comment.


  I haven't forgotten about this, but life has intervened and I'm not going to 
have time to work on it for a few days, maybe even a couple of weeks. If anyone 
else wants to run with it and take over, I won't be in the least bit offended. 
If not, I'll resume work at some point in the near to medium term future.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-08-20 Thread Nathaniel Graham 
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
version and kernel support it" to "Populate UDS_CREATION_TIME on Linux if Qt 
and kernel versions support it".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks