D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Eike Hein 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:78f83f5c7744: Dont set a window icon in 
Plasma::Dialog (authored by hein).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9209?vs=23520=23523

REVISION DETAIL
  https://phabricator.kde.org/D9209

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Martin Flöser 
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9209

To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Kai Uwe Broulik 
broulik added a comment.


  +1
  
  I still get an icon for plasma popups in tabbox and present windows

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9209

To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Eike Hein 
hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin.
Restricted Application added projects: Plasma, Frameworks.

REVISION SUMMARY
  Setting a window icon is costly enough to be worth avoiding when it's
  not actually needed.
  
  This is a resurrection of David's old patch:
  
  https://git.reviewboard.kde.org/r/128484/
  
  The concerns in the old discussion that led to its rejection are no
  longer valid today: In the meantime we implemented a way for apps to
  announce their .desktop file in a window hint, which KWin (and libtm)
  will fall back to to look up an icon if not set. As plasmashell does
  this, we can drop the setIcon call here and won't regress.

TEST PLAN
  The pinned systray popup dialog still gets the Plasma icon in the
  Present Windows effect.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9209

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart