D9287: disappearing scrollbars on mobile
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b2f61f8e3c9f: disappearing scrollbars on mobile (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23809=23814 REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES CMakeLists.txt src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml To: mart, #plasma, bshah, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart updated this revision to Diff 23809. mart added a comment. - fix deps REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23761=23809 BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES CMakeLists.txt src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in DefaultListItemBackground.qml:23 > does this change kill this? > > If so +1000 ah, yes it does, will remove REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
davidedmundson added a comment. If we have a runtime dep, we need to make it explicit in CMakeLists.txt. INLINE COMMENTS > DefaultListItemBackground.qml:23 > import QtQuick.Controls 1.0 as Controls > import QtQuick.Controls.Private 1.0 > import org.kde.plasma.core 2.0 as PlasmaCore does this change kill this? If so +1000 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart created this revision. mart added reviewers: Plasma, bshah. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY like other platforms, on mobile devices make scrollbars visible only when dragging/flicking, behavior on desktop unchanged it introduces a runtime dependency on kirigami, but was already kinda there but broken as the Settings singleton was already used. if this can't be done, i'll add something in plasmacore which reads as well the QT_QUICK_CONTROLS_MOBILE environment variable TEST PLAN scrollbar disappearing with the variable set, normal behavior otherwise REPOSITORY R242 Plasma Framework (Library) BRANCH phab/disappearScrollbars REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml To: mart, #plasma, bshah Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
