D9672: Don't emit error signal before we tried all list commands.

aacid closed this revision. aacid added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This already landed in bc4ea213b1d948b921236db29e78846c34496db7 REPOSITO

D9672: Don't emit error signal before we tried all list commands.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-ftp-list REVISION DETAIL https://phabricator.kde.org/D9672 To: wcpan, dfaure Cc: ngraham, cfeck, #frameworks, michaelh

D9672: Don't emit error signal before we tried all list commands.

wcpan updated this revision to Diff 26460. wcpan added a comment. Don't emit error signal before we tried all list commands. Use a special error code to skip error reporting. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9672?vs=24747&id=26460 BRANCH f

D9672: Don't emit error signal before we tried all list commands.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. ERR_* is KIO-wide, and isn't technically an enum. But the proper error code for no error is KJob::NoError (which is 0). Can you switch to that, and adjust the second comment,

D9672: Don't emit error signal before we tried all list commands.

cfeck edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9672 To: wcpan, dfaure Cc: cfeck, #frameworks, michaelh, ngraham

D9672: Don't emit error signal before we tried all list commands.

cfeck added a comment. Sorry for the late response, but we currently have no maintainer for the FTP code in KIO. From quickly checking, the intention looks good, but if the ERR_* codes are part of an enum, maybe add the special value -1 with a name there, instead of hardcoding the -1 va