jtamate updated this revision to Diff 25391.
jtamate added a comment.
I'm sorry for the inconvenience.
I'm going to divide the patch in two, the first part only changes lastTimeout
and should be safe.
nextTimeout part needs more thinking (if can be done).
REPOSITORY
R241 KIO
CHANGES
fvogt reopened this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Reverted in master as this broke various important ioslaves, like desktop and
trash.
I believe the issue is that the timeout fires immediately after construction,
without being
jtamate marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate, #frameworks, dfaure
Cc: broulik, ngraham, #dolphin
broulik added inline comments.
INLINE COMMENTS
> jtamate wrote in slavebase.cpp:117
> Could it be done without a review? I was busy doing arc land (with some
> problems) and I didn't notice.
Sure
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate,
jtamate added inline comments.
INLINE COMMENTS
> broulik wrote in slavebase.cpp:117
> Init with 0 in the constructor?
Could it be done without a review? I was busy doing arc land (with some
problems) and I didn't notice.
REPOSITORY
R241 KIO
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f7e00b40a6d3: Dont stat(/etc/localtime) between
read() and write() copying files (authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
broulik added inline comments.
INLINE COMMENTS
> slavebase.cpp:117
> +QElapsedTimer nextTimeout;
> +qint64 nextTimeoutMsecs;
> KIO::filesize_t totalSize;
Init with 0 in the constructor?
REPOSITORY
R241 KIO
BRANCH
elapsedtimer (branched from master)
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Well spotted!
REPOSITORY
R241 KIO
BRANCH
elapsedtimer (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate, #frameworks, dfaure
Cc: ngraham,
elvisangelaccio added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate, #frameworks, dfaure
Cc: ngraham, #dolphin
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate, #frameworks
Cc: ngraham, #dolphin
ngraham edited the summary of this revision.
ngraham added a subscriber: Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9844
To: jtamate, #frameworks
Cc: #dolphin
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
Unfortunately, QDateTime::currentDateTime() checks /etc/localtime
each time it is called.
Chaning to
12 matches
Mail list logo
