Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support
On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin Ottens. Committed on 12/11/2013 at 17:09. Pushed by ervin into branch 'frameworks'. Move cmake legacy to KDE4Support All the old CMake is now provided by KDE4Support as a porting aid. As a result, the top level CMakeLists.txt is as simple as possible. Nice, but I rather miss the dependencies summary. Another issue: tier4/kde4support/cmake/modules-tests/OpenEXR/CMakeLists.txt [from: cmake/modules-tests/OpenEXR/CMakeLists.txt - 100% similarity] R +0-0 OpenEXR is needed by tier1/kguiaddons/src/plugins/imageformats, it now omits building EXR support. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support
On 13/11/13 13:20, Christoph Feck wrote: On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: tier4/kde4support/cmake/modules-tests/OpenEXR/CMakeLists.txt [from: cmake/modules-tests/OpenEXR/CMakeLists.txt - 100% similarity] R +0-0 OpenEXR is needed by tier1/kguiaddons/src/plugins/imageformats, it now omits building EXR support. I've got a couple of RRs fixing that: Add to ECM: https://git.reviewboard.kde.org/r/113828/ Remove from kdelibs: https://git.reviewboard.kde.org/r/113834/ Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support
On Wednesday 13 November 2013 14:20:45 Christoph Feck wrote: On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote: Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin Ottens. Committed on 12/11/2013 at 17:09. Pushed by ervin into branch 'frameworks'. Move cmake legacy to KDE4Support All the old CMake is now provided by KDE4Support as a porting aid. As a result, the top level CMakeLists.txt is as simple as possible. Nice, but I rather miss the dependencies summary. Another issue: OK, I'll reintroduce that soon. tier4/kde4support/cmake/modules-tests/OpenEXR/CMakeLists.txt [from: cmake/modules-tests/OpenEXR/CMakeLists.txt - 100% similarity] R +0-0 OpenEXR is needed by tier1/kguiaddons/src/plugins/imageformats, it now omits building EXR support. Good catch. Let's try to get Alex patch in as soon as possible. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
