Re: KF 5.95-rc1 delayed
On samedi 11 juin 2022 21:19:33 CEST Nate Graham wrote: > On 6/9/22 11:18, Nate Graham wrote: > > Both are merged now. I think that should be everything. > > ...One more regression was found which is fixed with > https://invent.kde.org/frameworks/plasma-framework/-/commit/1fb2198fcee0ec90 > 9fed2f1cb6f2d16f27513d57. > > Can you please add that to the 5.25 tarball? Thanks! :) No, I added it to the 5.95 tarball instead ;) @ Packagers: plasma-framework v5.95.0-rc2 2e244362dd889b8512a9d6a87462e1a78879b866 5f5b6c95985e60b2e1d0b155fcb90bfc20186cb56f87d13c4b946f57fd22a55f sources/plasma-framework-5.95.0.tar.xz > with that included, I think we'll finally be done from the > plasma-framework perspective. Phew ;-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KF 5.95-rc1 delayed
On 6/9/22 11:18, Nate Graham wrote: Both are merged now. I think that should be everything. ...One more regression was found which is fixed with https://invent.kde.org/frameworks/plasma-framework/-/commit/1fb2198fcee0ec909fed2f1cb6f2d16f27513d57. Can you please add that to the 5.25 tarball? Thanks! :) with that included, I think we'll finally be done from the plasma-framework perspective. Nate
Re: KF 5.95-rc1 delayed
On Wed, Jun 8, 2022 at 11:01 PM Luca Carlon wrote: > > On Wed, Jun 8, 2022 at 11:41 AM David Faure wrote: > > > > > This also seems like something we should also fix before tagging: > > > > https://bugs.kde.org/show_bug.cgi?id=454635#c11 > > > > Luca, Marco: I need your input quickly on this one. > > https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/545 > > Isn't this also pretty relevant? > https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/535 Both are approved -- Marco Martin
Re: KF 5.95-rc1 delayed
On Wed, Jun 8, 2022 at 11:41 AM David Faure wrote: > > > This also seems like something we should also fix before tagging: > > > https://bugs.kde.org/show_bug.cgi?id=454635#c11 > > Luca, Marco: I need your input quickly on this one. https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/545 Isn't this also pretty relevant? https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/535 Regards. -- Dr. Luca Carlon Software Engineer
Re: KF 5.95-rc1 delayed
On mercredi 8 juin 2022 23:01:07 CEST Luca Carlon wrote: > On Wed, Jun 8, 2022 at 11:41 AM David Faure wrote: > > > > This also seems like something we should also fix before tagging: > > > > https://bugs.kde.org/show_bug.cgi?id=454635#c11 > > > > Luca, Marco: I need your input quickly on this one. > > https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/545 > > Isn't this also pretty relevant? > https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/535 Don't ask me, I'm plasma-illiterate. I just want to know when I can trigger the tagging for the release It has never been this complicated to get that information. Well, usually I didn't ask, I just went ahead, and then people told me about regressions they fixed ;). Now everything's in limbo state, with fixes up in the air (waiting for approval) and more changes going in, potentially breaking more stuff ;-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KF 5.95-rc1 delayed
On lundi 6 juin 2022 15:15:13 CEST Nate Graham wrote: > - Regression: > https://invent.kde.org/frameworks/knewstuff/-/merge_requests/186#note_462799 > - Proposed fix: > https://invent.kde.org/frameworks/knewstuff/-/merge_requests/187 Where are we with this one? Shall we finish the fix, or revert the change? > > This also seems like something we should also fix before tagging: > > https://bugs.kde.org/show_bug.cgi?id=454635#c11 Luca, Marco: I need your input quickly on this one. > >> - the regression in kirigami is fixed > >> https://invent.kde.org/frameworks/kirigami/-/merge_requests/548 The "bad" commit has been reverted in c0f5583b by Marco > >> - the regression in kio (trash) is fixed > >> https://invent.kde.org/frameworks/kio/-/merge_requests/854 I just reverted the "bad" commit in e31a779486 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KF 5.95-rc1 delayed
On 5/6/22 21:26, Ahmad Samir wrote: [...] Could be an issue due to change in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/178 KNewStuff header install locations: https://invent.kde.org/utilities/yakuake/-/merge_requests/61 https://invent.kde.org/games/ksirk/-/merge_requests/9 KnewStuff issue was solved by backporting the fixes to yakuake and ksirk in release/22.04. -- Ahmad Samir
Re: KF 5.95-rc1 delayed
On 5/6/22 20:57, Nicolas Fella wrote: On 6/5/22 20:53, David Faure wrote: Hi everyone, I'm delaying the tagging of KF 5.95 rc1 until: - the regression in kirigami is fixed https://invent.kde.org/frameworks/kirigami/-/merge_requests/548#note_462793 - the regression in kio (trash) is fixed https://invent.kde.org/frameworks/kio/-/merge_requests/854 Please let me know if there are other blocker issues. Hi, while we're at it we might also add https://bugs.kde.org/show_bug.cgi?id=454635 to the list of blockers. The relevant change that caused it is from plasma-framework: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500 Cheers Nico Could be an issue due to change in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/178 KNewStuff header install locations: https://invent.kde.org/utilities/yakuake/-/merge_requests/61 https://invent.kde.org/games/ksirk/-/merge_requests/9 -- Ahmad Samir
Re: KF 5.95-rc1 delayed
On 6/5/22 20:53, David Faure wrote: Hi everyone, I'm delaying the tagging of KF 5.95 rc1 until: - the regression in kirigami is fixed https://invent.kde.org/frameworks/kirigami/-/merge_requests/548#note_462793 - the regression in kio (trash) is fixed https://invent.kde.org/frameworks/kio/-/merge_requests/854 Please let me know if there are other blocker issues. Hi, while we're at it we might also add https://bugs.kde.org/show_bug.cgi?id=454635 to the list of blockers. The relevant change that caused it is from plasma-framework: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500 Cheers Nico
