Re: Reminder: Please add "Since" version info also to cmake macros and arguments

2016-02-07 Thread Alex Merry

On 2016-01-18 16:45, Friedrich W. H. Kossebau wrote:
Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. 
Kossebau:
I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came 
across
it, appending the Since behind the example, if that is the current 
syntax?


# Example:
#   kcoreaddons_add_plugin(kdeconnect_share JSON kdeconnect_share.json
SOURCES ${kdeconnect_share_SRCS})
#
# Since 5.10.0


Assuming this is a no-brainer, I just committed that, before I forget 
again

about it.


CMake docs aren't parsed by any tools outside of e-c-m, currently, so as 
long as it's clear to a human, it doesn't matter. Even in e-c-m, it's 
just text that gets put into html.


Thanks for catching these!

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Reminder: Please add "Since" version info also to cmake macros and arguments

2016-01-18 Thread Friedrich W. H. Kossebau
Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau:
> I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across
> it, appending the Since behind the example, if that is the current syntax?
> 
> # Example:
> #   kcoreaddons_add_plugin(kdeconnect_share JSON kdeconnect_share.json
> SOURCES ${kdeconnect_share_SRCS})
> #
> # Since 5.10.0

Assuming this is a no-brainer, I just committed that, before I forget again 
about it.

Cheers
Friedrich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel