Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 13, 2013, 11:05 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39948 --- This review has been submitted with commit 9c0e739a866eefd5aa9074ab1b5729611e64d001 by Aleix Pol to branch frameworks. - Commit Hook On Sept. 12, 2013, 6 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 12, 2013, 6 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39911 --- - Chusslove Illich On Sept. 12, 2013, 8 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 12, 2013, 8 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39913 --- Ship it! Ship It! - Chusslove Illich On Sept. 12, 2013, 8 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 12, 2013, 8 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112700: Prepare KI18n to move to tier2
On Sept. 12, 2013, 9:01 p.m., Chusslove Illich wrote: [: Aleix Pol Gonzalez :] NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? There was exactly this question earlier, discussion here: http://mail.kde.org/pipermail/kde-frameworks-devel/2012-November/ 001265.html Short version: the only reason ktranscript is in plugin form is performance (implementation detail), otherwise it is a non-separable part of ki18n. - Chusslove --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39911 --- On Sept. 12, 2013, 8 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 12, 2013, 8 p.m.) Review request for KDE Frameworks and Chusslove Illich. Description --- Properly specify the dependencies within frameworks so that it can be moved. NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs. Would it be possible to move this to kde-runtime or create a separate plugin what depends on something different? Diffs - staging/ki18n/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
