Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41019 --- Ping - Martin Klapetek On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41026 --- Ship it! Ship It! - John Layt On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41038 --- This review has been submitted with commit 273a89d6f10a9c2508ffd9a4394bb78417ebc126 by Martin Klapetek to branch frameworks. - Commit Hook On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 30, 2013, 2:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Changes --- RB didn't like the previous patch... Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs (updated) - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
