---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41196
---
Ship it!
Looks good, but why don't we replace KCategoryDrawer
On Oct. 4, 2013, 7 a.m., David Faure wrote:
Looks good, but why don't we replace KCategoryDrawer with
KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones?
It should be SC since v3 derives from v2 derives from v1.
It's not entirely source compatible since the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41199
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41105
---
staging/kcmutils/CMakeLists.txt
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
staging/kcmutils/CMakeLists.txt, line 23
http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23
Why removing these?
As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was
David Edmundson wrote:
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
staging/kcmutils/CMakeLists.txt, line 23
http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23
Why removing these?
As I understand it everything should compile with
I haven't moved anything.
Also this review is 3 different commits, one for each of the sentences
in the description.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
David Edmundson wrote:
I haven't moved anything.
Also this review is 3 different commits, one for each of the sentences
in the description.
Indeed, thanks!
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
