Re: Review Request 113045: Prepare KCMUtils for move to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41196 --- Ship it! Looks good, but why don't we replace KCategoryDrawer with KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones? It should be SC since v3 derives from v2 derives from v1. - David Faure On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
On Oct. 4, 2013, 7 a.m., David Faure wrote: Looks good, but why don't we replace KCategoryDrawer with KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones? It should be SC since v3 derives from v2 derives from v1. It's not entirely source compatible since the constructor changes and v1 needs deleting manually. Will be easy to change now that everything in kdelibs uses V3 style. Will make a new review today. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41196 --- On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41199 --- This review has been submitted with commit 23782b73ef829d9b07d352bcac8a6fe455e5d64f by David Edmundson to branch frameworks. - Commit Hook On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41105 --- staging/kcmutils/CMakeLists.txt http://git.reviewboard.kde.org/r/113045/#comment30168 Why removing these? - Aleix Pol Gonzalez On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: staging/kcmutils/CMakeLists.txt, line 23 http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23 Why removing these? As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was previously added here to make it compile before all the blah - QLiteralString(blah) changes. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41105 --- On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
David Edmundson wrote: On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: staging/kcmutils/CMakeLists.txt, line 23 http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23 Why removing these? As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was previously added here to make it compile before all the blah - QLiteralString(blah) changes. This discussion is exactly why you are supposed to make changes like this before the move in a separate patch, so that you can explain the above in a commit message. Then the move commit is 'clean'. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
David Edmundson wrote: I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. Indeed, thanks! Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
