Re: Review Request 113863: Remove WINCE specific cmake code paths
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 18, 2013, 2:34 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Removes WINCE specific code. It's not a supported platform anymore. Diffs (updated) - tier1/kcoreaddons/src/lib/CMakeLists.txt a1f81f7 tier1/kcoreaddons/src/lib/util/kuser_wince.cpp b96e4dc tier3/kinit/src/kdeinit/CMakeLists.txt 4ef0a9b tier3/kio/src/CMakeLists.txt 3800e85 tier3/kprintutils/src/CMakeLists.txt da0b7d5 tier4/kde4support/src/CMakeLists.txt 9046c96 Diff: http://git.reviewboard.kde.org/r/113863/diff/ Testing --- still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113863: Remove WINCE specific cmake code paths
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/#review43892 --- Ship it! Ship It! - Stephen Kelly On Nov. 18, 2013, 2:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 18, 2013, 2:34 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Removes WINCE specific code. It's not a supported platform anymore. Diffs - tier1/kcoreaddons/src/lib/CMakeLists.txt a1f81f7 tier1/kcoreaddons/src/lib/util/kuser_wince.cpp b96e4dc tier3/kinit/src/kdeinit/CMakeLists.txt 4ef0a9b tier3/kio/src/CMakeLists.txt 3800e85 tier3/kprintutils/src/CMakeLists.txt da0b7d5 tier4/kde4support/src/CMakeLists.txt 9046c96 Diff: http://git.reviewboard.kde.org/r/113863/diff/ Testing --- still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113863: Remove WINCE specific cmake code paths
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 15, 2013, 5:35 p.m.) Review request for Build System and KDE Frameworks. Changes --- added buildsystem group, hoping somebody will see it. Repository: kdelibs Description --- Removes WINCE specific code. It's not a supported platform anymore. Diffs - tier1/kcoreaddons/src/lib/CMakeLists.txt 53e85e8 tier1/kcoreaddons/src/lib/util/kuser_wince.cpp b96e4dc tier3/kinit/src/kdeinit/CMakeLists.txt bfa8659 tier3/kio/src/CMakeLists.txt 0b12bb8 tier3/kprintutils/src/CMakeLists.txt 7436f91 tier4/kde4support/src/CMakeLists.txt 7aec195 Diff: http://git.reviewboard.kde.org/r/113863/diff/ Testing --- still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113863: Remove WINCE specific cmake code paths
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/#review43763 --- tier3/kinit/src/kdeinit/CMakeLists.txt http://git.reviewboard.kde.org/r/113863/#comment31436 Shouldn't that line still be there? - Kevin Ottens On Nov. 15, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 15, 2013, 5:35 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Removes WINCE specific code. It's not a supported platform anymore. Diffs - tier1/kcoreaddons/src/lib/CMakeLists.txt 53e85e8 tier1/kcoreaddons/src/lib/util/kuser_wince.cpp b96e4dc tier3/kinit/src/kdeinit/CMakeLists.txt bfa8659 tier3/kio/src/CMakeLists.txt 0b12bb8 tier3/kprintutils/src/CMakeLists.txt 7436f91 tier4/kde4support/src/CMakeLists.txt 7aec195 Diff: http://git.reviewboard.kde.org/r/113863/diff/ Testing --- still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
