Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote: The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs. Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was. Alex Merry wrote: OK, thanks for the info. I reckon this doesn't make much sense any more, given we have multiple tier1 frameworks. About the best we could do is maybe follow Qt's layout, but I suspect that isn't worth it (if Qt even gives us all the necessary information). David Faure wrote: It was probably me. But many things changed since then :) There is no kdelibs anymore, and kdesrc-build makes it easy to specify the same prefix for everything. This leaves the case of compiling an app against system libs for Qt+KF5, but I think we should rather aim at making this work as easily as possible with a different prefix for the app, rather than forcing the installation of the app into the KF5 prefix (e.g. RPATH helps there, KDEDIRS is no more, so at most PATH and XDG_DATA_DIRS need to be set, and not even PATH if there's just one binary invoked by full path). Ah, there was another case I think, kdelibs configured by the distro with lots of custom paths (e.g. prefix of /usr but /etc instead of /usr/share/config for the config dir, and so on... that was more coolo's stuff). I suppose we have to find a solution for such things, but I'm no expert in this area (e.g. what would be convenient for distros). In any case the current stuff for sure doesn't work anymore, so a new solution will have to be used instead, if needed. +1 for removing the old magic. Okie dokie, since I got a +1 and no objections, I'm gonna commit this. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47008 --- On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47759 --- This review has been submitted with commit 2748a51aa61f6dbc93827e56d94ac92c9f0889b1 by Alex Merry to branch master. - Commit Hook On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 20, 2014, 10:34 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes --- Add extracmakemodules group. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47008 --- The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs. Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was. - Alexander Neundorf On Jan. 7, 2014, 9:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 7, 2014, 9:18 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote: The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs. Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was. OK, thanks for the info. I reckon this doesn't make much sense any more, given we have multiple tier1 frameworks. About the best we could do is maybe follow Qt's layout, but I suspect that isn't worth it (if Qt even gives us all the necessary information). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47008 --- On Jan. 7, 2014, 9:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 7, 2014, 9:18 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote: The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs. Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was. Alex Merry wrote: OK, thanks for the info. I reckon this doesn't make much sense any more, given we have multiple tier1 frameworks. About the best we could do is maybe follow Qt's layout, but I suspect that isn't worth it (if Qt even gives us all the necessary information). It was probably me. But many things changed since then :) There is no kdelibs anymore, and kdesrc-build makes it easy to specify the same prefix for everything. This leaves the case of compiling an app against system libs for Qt+KF5, but I think we should rather aim at making this work as easily as possible with a different prefix for the app, rather than forcing the installation of the app into the KF5 prefix (e.g. RPATH helps there, KDEDIRS is no more, so at most PATH and XDG_DATA_DIRS need to be set, and not even PATH if there's just one binary invoked by full path). Ah, there was another case I think, kdelibs configured by the distro with lots of custom paths (e.g. prefix of /usr but /etc instead of /usr/share/config for the config dir, and so on... that was more coolo's stuff). I suppose we have to find a solution for such things, but I'm no expert in this area (e.g. what would be convenient for distros). In any case the current stuff for sure doesn't work anymore, so a new solution will have to be used instead, if needed. +1 for removing the old magic. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47008 --- On Jan. 7, 2014, 9:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 7, 2014, 9:18 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake This appears to be a hangover from the KDE4 days, which would adjust certain paths to match the ones for kdelibs if you installed an application to the same prefix as kdelibs. This was probably to make KStandardDirs work properly in unusual setups. Diffs - kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169 Diff: https://git.reviewboard.kde.org/r/114904/diff/ Testing --- CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
