Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/#review47415 --- This review has been submitted with commit 96e4a9705b51e129d727be0c44e16d678a0ebfb6 by Marco Martin to branch master. - Commit Hook On Jan. 13, 2014, 8:02 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/ --- (Updated Jan. 13, 2014, 8:02 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- KDeclarative has very generic class names, therefore a bad practiche for public symbols. this moves it under KDeclarative:: namespace as discussed in the sprint Diffs - src/configpropertymap.h aeb41b5 src/configpropertymap.cpp 73e21d8 src/kdeclarative.h 84e8df4 src/kdeclarative.cpp 8aed99c src/private/kdeclarative_p.h 91e83cc src/private/kiconprovider.cpp 27eb8d1 src/private/kiconprovider_p.h 3773e0c src/private/kioaccessmanagerfactory.cpp ea73c45 src/private/kioaccessmanagerfactory_p.h 7f7cc73 src/private/qmlobject_p.h e5b32f8 src/private/rootcontext.cpp 503b430 src/private/rootcontext_p.h 805f7fa src/qmlobject.h 5028559 src/qmlobject.cpp d00ff40 tests/kdeclarativetest.cpp dd34d88 Diff: https://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/ --- (Updated Jan. 14, 2014, 10:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- KDeclarative has very generic class names, therefore a bad practiche for public symbols. this moves it under KDeclarative:: namespace as discussed in the sprint Diffs - src/configpropertymap.h aeb41b5 src/configpropertymap.cpp 73e21d8 src/kdeclarative.h 84e8df4 src/kdeclarative.cpp 8aed99c src/private/kdeclarative_p.h 91e83cc src/private/kiconprovider.cpp 27eb8d1 src/private/kiconprovider_p.h 3773e0c src/private/kioaccessmanagerfactory.cpp ea73c45 src/private/kioaccessmanagerfactory_p.h 7f7cc73 src/private/qmlobject_p.h e5b32f8 src/private/rootcontext.cpp 503b430 src/private/rootcontext_p.h 805f7fa src/qmlobject.h 5028559 src/qmlobject.cpp d00ff40 tests/kdeclarativetest.cpp dd34d88 Diff: https://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/ --- (Updated Jan. 13, 2014, 8:02 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- KDeclarative has very generic class names, therefore a bad practiche for public symbols. this moves it under KDeclarative:: namespace as discussed in the sprint Diffs - src/configpropertymap.h aeb41b5 src/configpropertymap.cpp 73e21d8 src/kdeclarative.h 84e8df4 src/kdeclarative.cpp 8aed99c src/private/kdeclarative_p.h 91e83cc src/private/kiconprovider.cpp 27eb8d1 src/private/kiconprovider_p.h 3773e0c src/private/kioaccessmanagerfactory.cpp ea73c45 src/private/kioaccessmanagerfactory_p.h 7f7cc73 src/private/qmlobject_p.h e5b32f8 src/private/rootcontext.cpp 503b430 src/private/rootcontext_p.h 805f7fa src/qmlobject.h 5028559 src/qmlobject.cpp d00ff40 tests/kdeclarativetest.cpp dd34d88 Diff: https://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/#review47353 --- Ship it! Looks good to me. - David Edmundson On Jan. 13, 2014, 8:02 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/ --- (Updated Jan. 13, 2014, 8:02 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- KDeclarative has very generic class names, therefore a bad practiche for public symbols. this moves it under KDeclarative:: namespace as discussed in the sprint Diffs - src/configpropertymap.h aeb41b5 src/configpropertymap.cpp 73e21d8 src/kdeclarative.h 84e8df4 src/kdeclarative.cpp 8aed99c src/private/kdeclarative_p.h 91e83cc src/private/kiconprovider.cpp 27eb8d1 src/private/kiconprovider_p.h 3773e0c src/private/kioaccessmanagerfactory.cpp ea73c45 src/private/kioaccessmanagerfactory_p.h 7f7cc73 src/private/qmlobject_p.h e5b32f8 src/private/rootcontext.cpp 503b430 src/private/rootcontext_p.h 805f7fa src/qmlobject.h 5028559 src/qmlobject.cpp d00ff40 tests/kdeclarativetest.cpp dd34d88 Diff: https://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
