Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 8:56 p.m.) Review request for Documentation, KDE

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49738 --- Ship it! Just please consider the note below, then ship it!

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49752 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49751 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 10:37 p.m.) Status -- This change has been

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49691 --- I locally fixed the 'if (WIN32)' issue in CMakeLists.txt and

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review48427 --- src/CMakeLists.txt

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-27 Thread Alexander Richardson
On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote: src/CMakeLists.txt, line 150 https://git.reviewboard.kde.org/r/115209/diff/2/?file=235239#file235239line150 I think you swapped the code for the two conditions (the part with 'cmd /k' should be inside if (WIN32) I guess You're

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review47997 --- Would it be possible to unify the two add_custom_command by

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 4:12 p.m.) Review request for Documentation, KDE