Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 8:56 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- $TARGET_FILE: seems to work also on Windows, drop the cmd /k Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs (updated) - CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49738 --- Ship it! Just please consider the note below, then ship it! src/xslt.cpp https://git.reviewboard.kde.org/r/115209/#comment34978 As you are here, can you please change this to const QString result = ... ? - Luigi Toscano On Feb. 13, 2014, 7:56 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 7:56 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49752 --- This review has been submitted with commit f138a8d634cedad858e7e2dc1dc4412c0b9360c6 by Alex Richardson to branch master. - Commit Hook On Feb. 13, 2014, 7:56 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 7:56 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49751 --- This review has been submitted with commit 0519d825ce2a41216a5126e22581c48cdd9d7586 by Alex Richardson to branch master. - Commit Hook On Feb. 13, 2014, 7:56 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 7:56 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 10:37 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49691 --- I locally fixed the 'if (WIN32)' issue in CMakeLists.txt and it fixes the build also on Mac OS X :) Nicely done! - Harald Fernengel On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 3:12 p.m.) Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review48427 --- src/CMakeLists.txt https://git.reviewboard.kde.org/r/115209/#comment34249 I think you swapped the code for the two conditions (the part with 'cmd /k' should be inside if (WIN32) I guess src/meinproc_common.cpp https://git.reviewboard.kde.org/r/115209/#comment34250 For changes like this and the other #define later I would like to have an opinion from kdewin group - Luigi Toscano On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 3:12 p.m.) Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote: src/CMakeLists.txt, line 150 https://git.reviewboard.kde.org/r/115209/diff/2/?file=235239#file235239line150 I think you swapped the code for the two conditions (the part with 'cmd /k' should be inside if (WIN32) I guess You're right. I fixed it locally, but forgot to update the review request On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote: src/meinproc_common.cpp, line 11 https://git.reviewboard.kde.org/r/115209/diff/2/?file=235241#file235241line11 For changes like this and the other #define later I would like to have an opinion from kdewin group According to http://msdn.microsoft.com/en-us/library/96ayss4b.aspx the _popen + pclose should be fine (as long as it is a non-gui executable, but that has been achieved by ecm_mark_nongui_executable). - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review48427 --- On Jan. 22, 2014, 4:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 4:12 p.m.) Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review47997 --- Would it be possible to unify the two add_custom_command by redefining only docbookl10nhelper_EXE into the WIN32 block? Could you please add the kdewin group as reviewers so that they can check if it works with gcc too? - Luigi Toscano On Jan. 22, 2014, 1:26 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 1:26 a.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115209: Fix KDoctools build on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Jan. 22, 2014, 4:12 p.m.) Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs (updated) - CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 Diff: https://git.reviewboard.kde.org/r/115209/diff/ Testing --- Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
