Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review47995 --- Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. - Aleix Pol Gonzalez On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. Luigi Toscano wrote: You ported KDE4_CREATE_HANDBOOK, which is widely used in kdelibs4-based code: http://lxr.kde.org/search?filestring=string=KDE4_CREATE_HANDBOOK On the other side, KDE4_CREATE_HTML_HANDBOOK has never been used in a stable version (not in 4 at least), please check the dates: http://mail.kde.org/pipermail/kde-buildsystem/2007-January/003643.html http://quickgit.kde.org/?p=kdelibs.gita=commith=61dd00ab3211bb7b76a94344ed8d577a6d194cf1 http://quickgit.kde.org/?p=kdelibs.gita=commith=82f7b6ba0f8be7d314ac780b9a873e98b6be39b2 Also: http://lxr.kde.org/search?filestring=string=KDE4_CREATE_HTML_HANDBOOK - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review47995 --- On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. You ported KDE4_CREATE_HANDBOOK, which is widely used in kdelibs4-based code: http://lxr.kde.org/search?filestring=string=KDE4_CREATE_HANDBOOK On the other side, KDE4_CREATE_HTML_HANDBOOK has never been used in a stable version (not in 4 at least), please check the dates: http://mail.kde.org/pipermail/kde-buildsystem/2007-January/003643.html http://quickgit.kde.org/?p=kdelibs.gita=commith=61dd00ab3211bb7b76a94344ed8d577a6d194cf1 http://quickgit.kde.org/?p=kdelibs.gita=commith=82f7b6ba0f8be7d314ac780b9a873e98b6be39b2 - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review47995 --- On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: Well, but frameworks are not only for frameworks. They're all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. Luigi Toscano wrote: You ported KDE4_CREATE_HANDBOOK, which is widely used in kdelibs4-based code: http://lxr.kde.org/search?filestring=string=KDE4_CREATE_HANDBOOK On the other side, KDE4_CREATE_HTML_HANDBOOK has never been used in a stable version (not in 4 at least), please check the dates: http://mail.kde.org/pipermail/kde-buildsystem/2007-January/003643.html http://quickgit.kde.org/?p=kdelibs.gita=commith=61dd00ab3211bb7b76a94344ed8d577a6d194cf1 http://quickgit.kde.org/?p=kdelibs.gita=commith=82f7b6ba0f8be7d314ac780b9a873e98b6be39b2 Luigi Toscano wrote: Also: http://lxr.kde.org/search?filestring=string=KDE4_CREATE_HTML_HANDBOOK Oh ok, sorry about the noise then. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review47995 --- On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48003 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48004 --- Ship it! Ship It! - Luigi Toscano On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48006 --- Well, I wouldn't expect many users in frameworks, but I can't even find any in my (somewhat out-of-date) checkout of KDE4 software; unsurprising, given it was deprecated for most/all of the KDE 4 era. So I'm in favour of this. - Alex Merry On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48059 --- This review has been submitted with commit fa347de2f5c5954393f6117909b472b4ccf0eb5c by David E. Narvaez to branch master. - Commit Hook On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 7:01 a.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- (Updated Jan. 22, 2014, 4:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel