Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-24 Thread Kevin Krammer
On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: If this is tier 1 now, please don't forget to update the wiki and the yaml file. Hrvoje Senjan wrote: Also find_dependency(KF5JS @KF5_VERSION@) can go away =) Both good catches. All in now - Kevin

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-23 Thread Hrvoje Senjan
On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: If this is tier 1 now, please don't forget to update the wiki and the yaml file. Also find_dependency(KF5JS @KF5_VERSION@) can go away =) - Hrvoje --- This is an automatically

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50522 --- I tried to run a standalone non-GUI program using ki18n:

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Alex Merry
On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 1:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Chusslove Illich
On Feb. 22, 2014, 2:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 2 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Chusslove Illich
On Feb. 22, 2014, 2:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50531 --- Ship it! Ship It! - Chusslove Illich On Feb. 22, 2014, 3

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50532 --- This review has been submitted with commit

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 2:15 p.m.) Status -- This change has been

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Christoph Feck
On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: I tried to run a standalone non-GUI program using ki18n: #include QDebug #include KLocalizedString int main (int argc, char *argv[]) { setlocale (LC_ALL, );

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50535 --- If this is tier 1 now, please don't forget to update the wiki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-20 Thread Kevin Krammer
On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: Any concerns left on that patch? It'd be nice to have it in alpha 2. I guess the main problem is that due to a weird JavaScriptCore internal thing the unit test crashes on exit. See https://bugreports.qt-project.org/browse/QTBUG-9622 for

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-20 Thread Kevin Ottens
On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: Any concerns left on that patch? It'd be nice to have it in alpha 2. Kevin Krammer wrote: I guess the main problem is that due to a weird JavaScriptCore internal thing the unit test crashes on exit. See

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-16 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 16, 2014, 6:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-15 Thread Chusslove Illich
On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-06 Thread Kevin Krammer
On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Kevin Krammer
On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Thanks :) Good to hear that it works properly, I guess

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Chusslove Illich
On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Christoph Feck
On Wednesday 05 February 2014 22:18:54 Chusslove Illich wrote: I don't see significant benefit in ki18n being tier 1 Maybe not significant, but looking at ever-appearing difficulties with providing proper translations of Qt applications in KDE repositories, the porting effort is worth it.