Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/#review49241 --- Ship it! Ship It! - David Faure On Feb. 6, 2014, 10:35 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 6, 2014, 10:35 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Hide a private method and a private slot of KComboBox behind the d-pointer Also: --Change lineEdit() for isEditable() for checking whether the kcombobox is editable. Diffs - src/kcombobox.h e59d72b src/kcombobox.cpp 2cfe6e7 Diff: https://git.reviewboard.kde.org/r/115524/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 8, 2014, 9:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Hide a private method and a private slot of KComboBox behind the d-pointer Also: --Change lineEdit() for isEditable() for checking whether the kcombobox is editable. Diffs - src/kcombobox.h e59d72b src/kcombobox.cpp 2cfe6e7 Diff: https://git.reviewboard.kde.org/r/115524/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/#review49300 --- This review has been submitted with commit 6bac05aad6f4d326fda773192e8b2530bf967a47 by David Gil to branch master. - Commit Hook On Feb. 6, 2014, 10:35 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 6, 2014, 10:35 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Hide a private method and a private slot of KComboBox behind the d-pointer Also: --Change lineEdit() for isEditable() for checking whether the kcombobox is editable. Diffs - src/kcombobox.h e59d72b src/kcombobox.cpp 2cfe6e7 Diff: https://git.reviewboard.kde.org/r/115524/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 6, 2014, 10:35 p.m.) Review request for KDE Frameworks. Changes --- Uncomment line. Repository: kcompletion Description --- Hide a private method and a private slot of KComboBox behind the d-pointer Also: --Change lineEdit() for isEditable() for checking whether the kcombobox is editable. Diffs (updated) - src/kcombobox.h e59d72b src/kcombobox.cpp 2cfe6e7 Diff: https://git.reviewboard.kde.org/r/115524/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
