Re: Review Request 118846: Turn KLauncher into a QGuiApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60749 --- This review has been submitted with commit 7941d45f08e8906447cfd0df77801cabe3f4f8ec by Martin Gräßlin to branch master. - Commit Hook On June 20, 2014, 11:51 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 20, 2014, 11:51 a.m.) Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118846: Turn KLauncher into a QGuiApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 23, 2014, 6:30 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118846: Turn KLauncher into a QGuiApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60591 --- Ship it! looks good to me - Harald Sitter On June 20, 2014, 11:51 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 20, 2014, 11:51 a.m.) Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118846: Turn KLauncher into a QGuiApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60615 --- Strange, why wasn't this necessary in kdelibs4? - David Faure On June 20, 2014, 11:51 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 20, 2014, 11:51 a.m.) Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118846: Turn KLauncher into a QGuiApplication
On June 20, 2014, 7:05 p.m., David Faure wrote: Strange, why wasn't this necessary in kdelibs4? see the linked bug report. It's basically a regression due to introducing platform detection (X11 vs. Wayland) in both klauncher and KWindowSystem. My first idea to fix it was to check for DISPLAY variable set instead of checking the platformName, but going deeper showed that it would fail in all the KWindowSystem checks, too. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60615 --- On June 20, 2014, 1:51 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 20, 2014, 1:51 p.m.) Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118846: Turn KLauncher into a QGuiApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60630 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 20, 2014, 11:51 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 20, 2014, 11:51 a.m.) Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 336488 https://bugs.kde.org/show_bug.cgi?id=336488 Repository: kinit Description --- Turn KLauncher into a QGuiApplication klauncher uses the X11 windowing system which means it should be a QGuiApplication. This is important as otherwise all the runtime checks for whether X11 is used will fail. This is not only inside KLauncher itself, but also in KWindowSystem. BUG: 336488 Diffs - src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a Diff: https://git.reviewboard.kde.org/r/118846/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
