Re: Review Request 119377: Add highlighting commands
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ --- (Updated July 26, 2014, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console. This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/). The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine). I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try. Diffs - src/CMakeLists.txt 2ec52b25dddacdbedf16b908c36fd71f11a889ae src/syntax/katehighlight.h 5c34fb0c3747e72137484fa369a0804f87fb4c43 src/syntax/katehighlight.cpp 05b787cc9c16b2fa6c8ac82c7e809bb0ab8f5835 src/syntax/katehighlightingcmds.h PRE-CREATION src/syntax/katehighlightingcmds.cpp PRE-CREATION src/syntax/katesyntaxmanager.h 568154154149e7c649ec2c023c7e43d44ad07ea4 src/syntax/katesyntaxmanager.cpp ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46 src/utils/kateglobal.cpp 5a1cc220e8800a0e4e9203432ea5ba5f72921c21 Diff: https://git.reviewboard.kde.org/r/119377/diff/ Testing --- Using the two new commands on my development machine yields the desired results. Thanks, Christoph Rüßler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119377: Add highlighting commands
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ --- (Updated Juli 23, 2014, 5:08 nachm.) Review request for KDE Frameworks and Christoph Cullmann. Changes --- Rename the new files to “katehighlightingcmds”. Repository: ktexteditor Description --- Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console. This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/). The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine). I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try. Diffs (updated) - src/CMakeLists.txt 2ec52b25dddacdbedf16b908c36fd71f11a889ae src/syntax/katehighlight.h 5c34fb0c3747e72137484fa369a0804f87fb4c43 src/syntax/katehighlight.cpp 05b787cc9c16b2fa6c8ac82c7e809bb0ab8f5835 src/syntax/katehighlightingcmds.h PRE-CREATION src/syntax/katehighlightingcmds.cpp PRE-CREATION src/syntax/katesyntaxmanager.h 568154154149e7c649ec2c023c7e43d44ad07ea4 src/syntax/katesyntaxmanager.cpp ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46 src/utils/kateglobal.cpp 5a1cc220e8800a0e4e9203432ea5ba5f72921c21 Diff: https://git.reviewboard.kde.org/r/119377/diff/ Testing --- Using the two new commands on my development machine yields the desired results. Thanks, Christoph Rüßler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119377: Add highlighting commands
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/#review62977 --- Ship it! Ship It! - Christoph Cullmann On July 23, 2014, 3:08 p.m., Christoph Rüßler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ --- (Updated July 23, 2014, 3:08 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console. This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/). The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine). I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try. Diffs - src/CMakeLists.txt 2ec52b25dddacdbedf16b908c36fd71f11a889ae src/syntax/katehighlight.h 5c34fb0c3747e72137484fa369a0804f87fb4c43 src/syntax/katehighlight.cpp 05b787cc9c16b2fa6c8ac82c7e809bb0ab8f5835 src/syntax/katehighlightingcmds.h PRE-CREATION src/syntax/katehighlightingcmds.cpp PRE-CREATION src/syntax/katesyntaxmanager.h 568154154149e7c649ec2c023c7e43d44ad07ea4 src/syntax/katesyntaxmanager.cpp ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46 src/utils/kateglobal.cpp 5a1cc220e8800a0e4e9203432ea5ba5f72921c21 Diff: https://git.reviewboard.kde.org/r/119377/diff/ Testing --- Using the two new commands on my development machine yields the desired results. Thanks, Christoph Rüßler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119377: Add highlighting commands
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/#review62738 --- Think that is a nice thingy for people working on the own HL. What would be nice before you add that: rename the file from katehighlightreload to katehighlightingcmds or so, as it contains more than just the reload, and later might get more. - Christoph Cullmann On July 20, 2014, 12:29 p.m., Christoph Rüßler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ --- (Updated July 20, 2014, 12:29 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console. This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/). The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine). I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try. Diffs - src/utils/kateglobal.cpp 27128529dde920dad92cc06e11f8a687a8880599 src/CMakeLists.txt 0862cff2c2f60c0fc89a9f6a2b427425ac18349c src/syntax/katehighlight.h 22d75b9e344d20f9dcbe1e9b94aebe169394c2db src/syntax/katehighlight.cpp b82354e5c1f41e9a843f4478332fe62f7cad95ea src/syntax/katehighlightreload.h PRE-CREATION src/syntax/katehighlightreload.cpp PRE-CREATION src/syntax/katesyntaxmanager.h 568154154149e7c649ec2c023c7e43d44ad07ea4 src/syntax/katesyntaxmanager.cpp ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46 Diff: https://git.reviewboard.kde.org/r/119377/diff/ Testing --- Using the two new commands on my development machine yields the desired results. Thanks, Christoph Rüßler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
