Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Exclude X11 when building for Wayland Diffs - CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c Diff: https://git.reviewboard.kde.org/r/120306/diff/ Testing --- Thanks, Pier Luigi Fiorini
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review99474 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Sept. 21, 2014, 2:50 p.m., Pier Luigi Fiorini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120306/ > --- > > (Updated Sept. 21, 2014, 2:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Exclude X11 when building for Wayland > > > Diffs > - > > CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 > src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c > > Diff: https://git.reviewboard.kde.org/r/120306/diff/ > > > Testing > --- > > > Thanks, > > Pier Luigi Fiorini > >
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67169 --- I do not understand why this should be mutual exclusive. One of the nice new things in Qt 5 is that we can support multiple platforms in one library. We do not want Distros to have to ship everything twice: once for Wayland and once for X11. - Martin Gräßlin On Sept. 21, 2014, 4:50 p.m., Pier Luigi Fiorini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120306/ > --- > > (Updated Sept. 21, 2014, 4:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Exclude X11 when building for Wayland > > > Diffs > - > > CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 > src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c > > Diff: https://git.reviewboard.kde.org/r/120306/diff/ > > > Testing > --- > > > Thanks, > > Pier Luigi Fiorini > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67165 --- Why are we exclusive at compile time? - David Edmundson On Sept. 21, 2014, 2:50 p.m., Pier Luigi Fiorini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120306/ > --- > > (Updated Sept. 21, 2014, 2:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Exclude X11 when building for Wayland > > > Diffs > - > > CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 > src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c > > Diff: https://git.reviewboard.kde.org/r/120306/diff/ > > > Testing > --- > > > Thanks, > > Pier Luigi Fiorini > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
