Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-10-11 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review99926 --- Reposting here, proposing to reopen it. After a while: I

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated July 11, 2016, 4:15 p.m.) Status -- This change has been

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > >

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-05-06 Thread David Faure
> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > >

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Kevin Funk
> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > >

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review94684 --- Let's do something about this. I see two solutions for this:

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-12-02 Thread Kevin Funk
> On Aug. 27, 2015, 9:57 p.m., Patrick Spendrin wrote: > > Wait, Wait, Wait. > > 1) The difference between console apps and GUI apps is that console apps > > actually have stdin, stdout and stderr streams. So using or not using a > > console app actually depends on if you need to have these

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84496 --- Wait, Wait, Wait. 1) The difference between console apps and

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread Kevin Funk
On Aug. 26, 2015, 7:24 a.m., David Faure wrote: It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead? These are non gui executables, so from an API point of view, using this function is correct. Would we ever want a

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread David Faure
On Aug. 26, 2015, 7:24 a.m., David Faure wrote: It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead? These are non gui executables, so from an API point of view, using this function is correct. Would we ever want a

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread David Faure
On Aug. 26, 2015, 7:24 a.m., David Faure wrote: It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead? These are non gui executables, so from an API point of view, using this function is correct. Would we ever want a

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84389 --- It sounds to me like ecm_mark_non_gui_executable doesn't do

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-26 Thread Kevin Funk
On Aug. 26, 2015, 7:24 a.m., David Faure wrote: It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead? These are non gui executables, so from an API point of view, using this function is correct. Would we ever want a

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84357 --- I accidentally pushed this, sorry. Could you review? -

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated Aug. 24, 2015, 1:36 p.m.) Review request for KDE Frameworks,