Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-23 Thread Boudhayan Gupta
> On Oct. 23, 2015, 12:11 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, lines 162-168 > > > > > > Maybe we should extend the documentation a little bit? E.g. that it's > > only a hint to the WM, that

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-23 Thread Martin Gräßlin
> On Oct. 23, 2015, 8:41 a.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindoweffects.cpp, line 333 > > > > > > nitpick: unrelated whitespace change. > > Boudhayan Gupta wrote: > That's my text-editor

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87294 --- src/kwindoweffects.h (lines 162 - 168)

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, line 172 > > > > > > looks like you removed an empty line > > Boudhayan Gupta wrote: > I don't understand this issue. Removed

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87206 --- src/kwindoweffects.h (line 167)

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, line 172 > > > > > > looks like you removed an empty line I don't understand this issue. Removed an empty line? - Boudhayan

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/ --- (Updated Oct. 21, 2015, 8:53 p.m.) Review request for KDE Frameworks and

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
> On Oct. 21, 2015, 4:49 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87207 --- src/kwindoweffects.cpp (line 95)

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
> On Oct. 21, 2015, 4:49 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/ --- (Updated Oct. 21, 2015, 5:25 p.m.) Review request for KDE Frameworks and