Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated May 26, 2016, 6:13 p.m.) Status -- This change has been

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95832 --- Ship it! Thanks a lot. This now looks good for me (could

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated Kvě. 26, 2016, 1:07 odp.) Review request for Kate, KDE

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95827 --- Ok, I think one more revision and we're good to go. Thanks

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated Kvě. 26, 2016, 10:06 dop.) Review request for Kate, KDE

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Dominik Haumann
> On Mai 24, 2016, 10:05 nachm., Milian Wolff wrote: > > Jan, I think you've not yet uploaded the updated patch? > > Jan Grulich wrote: > That's right, because I wasn't successfull fixing this in a way Dominik > wanted me to fix and right now I don't have unfortunately time for that. hm,

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Jan Grulich
> On Kvě. 24, 2016, 10:05 odp., Milian Wolff wrote: > > Jan, I think you've not yet uploaded the updated patch? That's right, because I wasn't successfull fixing this in a way Dominik wanted me to fix and right now I don't have unfortunately time for that. - Jan

Re: Review Request 127843: Properly remove composed characters

2016-05-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95764 --- Jan, I think you've not yet uploaded the updated patch? -

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Jan Grulich
> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

2016-05-16 Thread Dominik Haumann
> On May 7, 2016, 9:40 a.m., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

2016-05-09 Thread Jan Grulich
> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

2016-05-07 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95257 --- I can see that the patch works, since Qt's QTextLayout

Re: Review Request 127843: Properly remove composed characters

2016-05-07 Thread Dominik Haumann
> On May 5, 2016, 10:07 a.m., Jan Grulich wrote: > > Looks that review board cannot handle indic characters. I posted them here: > > https://paste.kde.org/piptzo584 > > Dominik Haumann wrote: > I guess backspace should remove the entire character, i.e. as much as > when navigating with

Re: Review Request 127843: Properly remove composed characters

2016-05-07 Thread Dominik Haumann
> On May 5, 2016, 10:07 a.m., Jan Grulich wrote: > > Looks that review board cannot handle indic characters. I posted them here: > > https://paste.kde.org/piptzo584 I guess backspace should remove the entire character, i.e. as much as when navigating with the cursor, right? There is also a

Re: Review Request 127843: Properly remove composed characters

2016-05-05 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95199 --- Looks that review board cannot handle indic characters. I