Re: Review Request 127900: Fix redirection of absolut Urls

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/
---

(Updated May 14, 2016, 1:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.


Changes
---

Submitted with commit d6118e0d79fc5b1abda3e2d1e506bb7bde160747 by Andreas 
Cord-Landwehr to branch master.


Bugs: 354748
http://bugs.kde.org/show_bug.cgi?id=354748


Repository: attica


Description
---

Redirection only worked with relative urls. Yet, e.g. the http to https
redirection on KDE servers uses absolute paths, which resulted in an
empty url, since the reply attribute was not relative.

This patch adds a case distinction for redirecting absolut and relative
paths.

BUG: 354748


Diffs
-

  src/atticabasejob.cpp f73cb43 

Diff: https://git.reviewboard.kde.org/r/127900/diff/


Testing
---

Manual testing with GHNS for documentation in KDevelop.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/#review95463
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On May 13, 2016, 9:07 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127900/
> ---
> 
> (Updated May 13, 2016, 9:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.
> 
> 
> Bugs: 354748
> http://bugs.kde.org/show_bug.cgi?id=354748
> 
> 
> Repository: attica
> 
> 
> Description
> ---
> 
> Redirection only worked with relative urls. Yet, e.g. the http to https
> redirection on KDE servers uses absolute paths, which resulted in an
> empty url, since the reply attribute was not relative.
> 
> This patch adds a case distinction for redirecting absolut and relative
> paths.
> 
> BUG: 354748
> 
> 
> Diffs
> -
> 
>   src/atticabasejob.cpp f73cb43 
> 
> Diff: https://git.reviewboard.kde.org/r/127900/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with GHNS for documentation in KDevelop.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/
---

(Updated Mai 13, 2016, 7:07 nachm.)


Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.


Changes
---

Took the wrong diff in the last patch update.


Bugs: 354748
http://bugs.kde.org/show_bug.cgi?id=354748


Repository: attica


Description
---

Redirection only worked with relative urls. Yet, e.g. the http to https
redirection on KDE servers uses absolute paths, which resulted in an
empty url, since the reply attribute was not relative.

This patch adds a case distinction for redirecting absolut and relative
paths.

BUG: 354748


Diffs (updated)
-

  src/atticabasejob.cpp f73cb43 

Diff: https://git.reviewboard.kde.org/r/127900/diff/


Testing
---

Manual testing with GHNS for documentation in KDevelop.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/
---

(Updated Mai 13, 2016, 6:29 nachm.)


Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.


Bugs: 354748
http://bugs.kde.org/show_bug.cgi?id=354748


Repository: attica


Description
---

Redirection only worked with relative urls. Yet, e.g. the http to https
redirection on KDE servers uses absolute paths, which resulted in an
empty url, since the reply attribute was not relative.

This patch adds a case distinction for redirecting absolut and relative
paths.

BUG: 354748


Diffs (updated)
-

  src/atticabasejob.cpp f73cb43 

Diff: https://git.reviewboard.kde.org/r/127900/diff/


Testing
---

Manual testing with GHNS for documentation in KDevelop.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/#review95439
---




src/atticabasejob.cpp (line 60)


Get 
`m_reply->attribute(QNetworkRequest::RedirectionTargetAttribute).toUrl()` into 
a variable?

also space in `if_(`



src/atticabasejob.cpp (line 63)


remove commented code.



src/atticabasejob.cpp (line 65)


`} else {`


- Aleix Pol Gonzalez


On May 12, 2016, 7:17 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127900/
> ---
> 
> (Updated May 12, 2016, 7:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.
> 
> 
> Bugs: 354748
> http://bugs.kde.org/show_bug.cgi?id=354748
> 
> 
> Repository: attica
> 
> 
> Description
> ---
> 
> Redirection only worked with relative urls. Yet, e.g. the http to https
> redirection on KDE servers uses absolute paths, which resulted in an
> empty url, since the reply attribute was not relative.
> 
> This patch adds a case distinction for redirecting absolut and relative
> paths.
> 
> BUG: 354748
> 
> 
> Diffs
> -
> 
>   src/atticabasejob.cpp f73cb432212be63cff2ae1118c602cc3bae6d615 
> 
> Diff: https://git.reviewboard.kde.org/r/127900/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with GHNS for documentation in KDevelop.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/#review95440
---


Ship it!




Ship It!

- Jeremy Whiting


On May 12, 2016, 11:17 a.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127900/
> ---
> 
> (Updated May 12, 2016, 11:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.
> 
> 
> Bugs: 354748
> http://bugs.kde.org/show_bug.cgi?id=354748
> 
> 
> Repository: attica
> 
> 
> Description
> ---
> 
> Redirection only worked with relative urls. Yet, e.g. the http to https
> redirection on KDE servers uses absolute paths, which resulted in an
> empty url, since the reply attribute was not relative.
> 
> This patch adds a case distinction for redirecting absolut and relative
> paths.
> 
> BUG: 354748
> 
> 
> Diffs
> -
> 
>   src/atticabasejob.cpp f73cb432212be63cff2ae1118c602cc3bae6d615 
> 
> Diff: https://git.reviewboard.kde.org/r/127900/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with GHNS for documentation in KDevelop.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/
---

(Updated Mai 12, 2016, 5:17 nachm.)


Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk.


Bugs: 354748
http://bugs.kde.org/show_bug.cgi?id=354748


Repository: attica


Description
---

Redirection only worked with relative urls. Yet, e.g. the http to https
redirection on KDE servers uses absolute paths, which resulted in an
empty url, since the reply attribute was not relative.

This patch adds a case distinction for redirecting absolut and relative
paths.

BUG: 354748


Diffs
-

  src/atticabasejob.cpp f73cb432212be63cff2ae1118c602cc3bae6d615 

Diff: https://git.reviewboard.kde.org/r/127900/diff/


Testing (updated)
---

Manual testing with GHNS for documentation in KDevelop.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel