Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/ --- (Updated Oct. 26, 2016, 2:54 a.m.) Status -- This change has been

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/#review99391 --- personally, I don't think it's a good idea to use QString

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/ --- (Updated Sept. 20, 2016, 1:19 p.m.) Review request for KDE Frameworks.

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

> On Sept. 19, 2016, 8:08 nachm., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 477 > > > > > > Using readLineInto() is really useful to reduce unnecessary > > allocations. However the

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/#review99302 --- I think you might be better off (and faster) if you use

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

> On Sept. 19, 2016, 9:08 p.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 478 > > > > > > If I read this correctly we no longer handle leading/trailing spaces > > properly. Does the

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/#review99278 --- Thanks for looking into this! When I wrote the code I