Re: Review Request 128955: Minor optimisation/cleanup in scripengine loading

2016-09-20 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128955/
---

(Updated Sept. 20, 2016, 6:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 580af56fe531dda8acb54c7b1698371813767575 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Avoid creating a KPLuginInfo list from KPluginMetaData


Diffs
-

  src/plasma/scripting/scriptengine.cpp 
e6883d40b9e4aba963d0195122358fa5554d5897 

Diff: https://git.reviewboard.kde.org/r/128955/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 128955: Minor optimisation/cleanup in scripengine loading

2016-09-20 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128955/#review99326
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 20, 2016, 1:36 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128955/
> ---
> 
> (Updated Sept. 20, 2016, 1:36 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Avoid creating a KPLuginInfo list from KPluginMetaData
> 
> 
> Diffs
> -
> 
>   src/plasma/scripting/scriptengine.cpp 
> e6883d40b9e4aba963d0195122358fa5554d5897 
> 
> Diff: https://git.reviewboard.kde.org/r/128955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>