Re: Review Request 128970: Add cross compile support for meinproc5.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/
---

(Updated Sept. 26, 2016, 1:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit d6f7aa2a1641569e119ba81697fe29104b82fb5e by Ralf Habacker 
to branch master.


Repository: kdoctools


Description
---

Add cross compile support for meinproc5.


Diffs
-

  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 

Diff: https://git.reviewboard.kde.org/r/128970/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Re: Review Request 128970: Add cross compile support for meinproc5.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99532
---


Ship it!




Ship It!

- Luigi Toscano


On Sept. 21, 2016, 11:44 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128970: Add cross compile support for meinproc5.

[Luigi Toscano]

> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 60
> > 
> >
> > So, I inherited kdoctools with this code commented - do you have an 
> > idea why it was like this, and why your patch would solve the (old) issues, 
> > or if they are not relevant anymore? My cross-compilation knowledge is 
> > limited.
> 
> Ralf Habacker wrote:
> The mentioned message came from the commit 
> https://github.com/KDE/kdelibs/commit/39dfbe0910228f0dccc0297e59ba47cf7e9b0d7c
>  and indicates that the initial attempt has been reverted because of 
> unfinished state.
> 
> The attempt this commit belongs to has been finished and is working (see 
> https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:KF526)
>  and specific for kdoctools here 
> https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF526/mingw32-kdoctools
> 
> If you want I can refactor the patch to let this commented out stuff 
> inside.

I see; the codepath for the non-crosscompiling case is untouched, so I'm fine 
then.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99352
---


On Sept. 21, 2016, 11:44 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128970: Add cross compile support for meinproc5.

[Ralf Habacker]

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 60
> > 
> >
> > So, I inherited kdoctools with this code commented - do you have an 
> > idea why it was like this, and why your patch would solve the (old) issues, 
> > or if they are not relevant anymore? My cross-compilation knowledge is 
> > limited.

The mentioned message came from the commit 
https://github.com/KDE/kdelibs/commit/39dfbe0910228f0dccc0297e59ba47cf7e9b0d7c 
and indicates that the initial attempt has been reverted because of unfinished 
state.

The attempt this commit belongs to has been finished and is working (see 
https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:KF526)
 and specific for kdoctools here 
https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF526/mingw32-kdoctools

If you want I can refactor the patch to let this commented out stuff inside.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99352
---


On Sept. 21, 2016, 11:44 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128970: Add cross compile support for meinproc5.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99352
---




src/CMakeLists.txt 


So, I inherited kdoctools with this code commented - do you have an idea 
why it was like this, and why your patch would solve the (old) issues, or if 
they are not relevant anymore? My cross-compilation knowledge is limited.


- Luigi Toscano


On Sept. 21, 2016, 11:44 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>