Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-30 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Sept. 30, 2016, 11:15 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Changes
---

Submitted with commit 00acf17a2071d86e218d3d49a0e53157eaa265dd by Jan Grulich 
to branch master.


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/manager_p.h 50c3c34 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99667
---


Ship it!




looks good to me

- David Edmundson


On Sept. 29, 2016, 7:10 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 29, 2016, 7:10 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich 


> On Zář. 29, 2016, 10:22 dop., Aleix Pol Gonzalez wrote:
> > Since I applied your patch, I get this output when starting plasma:
> > 
> > ```
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const 
> > QVariantMap &) Unhandled property "AllDevices"
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const 
> > QVariantMap &) Unhandled property "Devices"
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const 
> > QVariantMap &) Unhandled property "GlobalDnsConfiguration"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString 
> > &, const QVariant &) Unhandled property "S390Subchannels"
> > ```

You can ignore that, that was there even before. 

For "AllDevices" and "Devices" properties we ignore them intentionally, because 
there is also "DeviceAdded" and "DeviceRemoved" signal so there is no need to 
check that twice, maybe just supress the error message for those. For the rest 
we still don't have these properties implemented as they come from latest NM 
versions and we are a bit behind.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99656
---


On Zář. 29, 2016, 7:10 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Zář. 29, 2016, 7:10 dop.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99656
---



Since I applied your patch, I get this output when starting plasma:

```
void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap 
&) Unhandled property "AllDevices"
void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap 
&) Unhandled property "Devices"
void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap 
&) Unhandled property "GlobalDnsConfiguration"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "LldpNeighbors"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "Real"
virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, 
const QVariant &) Unhandled property "S390Subchannels"
```

- Aleix Pol Gonzalez


On Sept. 29, 2016, 9:10 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 29, 2016, 9:10 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Zář. 29, 2016, 7:10 dop.)


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Changes
---

Initialize modemCapabilities as well.


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs (updated)
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/manager_p.h 50c3c34 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99570
---




src/modemdevice.cpp 


modemCapabilities is not checked in propertyChanged


- David Edmundson


On Sept. 27, 2016, 12:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 12:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Aleix Pol Gonzalez 


> On Sept. 27, 2016, 2:41 p.m., Aleix Pol Gonzalez wrote:
> > +1 definitely a step forward.

FWIW, testing it, seems to work fine.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99587
---


On Sept. 27, 2016, 2:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99587
---



+1 definitely a step forward.

- Aleix Pol Gonzalez


On Sept. 27, 2016, 2:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Zář. 27, 2016, 12:07 odp.)


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Changes
---

Avoid code duplication


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs (updated)
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/manager_p.h 50c3c34 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Aleix Pol Gonzalez 


> On Sept. 27, 2016, 12:55 p.m., Anthony Fieroni wrote:
> > src/accesspoint.cpp, line 84
> > 
> >
> > Can you try to add a function to remove this annoying code duplication?

+1


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99575
---


On Sept. 27, 2016, 9:59 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 9:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99575
---




src/accesspoint.cpp (line 69)


Can you try to add a function to remove this annoying code duplication?


- Anthony Fieroni


On Sept. 27, 2016, 10:59 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 10:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-27 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Zář. 27, 2016, 7:59 dop.)


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich