Re: Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/ --- (Updated Oct. 15, 2016, midnight) Status -- This change has been mar

Re: Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/ --- (Updated Oct. 13, 2016, 2:30 p.m.) Review request for KDE Frameworks. R

Re: Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/#review99980 --- Ship it! Makes sense to me, I'd add an assert as well, to

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() > > David Edmundson wrote: > I did think about that, but what if the userspace code is

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 3:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() > > David Edmundson wrote: > I did think about that, but what if the userspace code is:

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() I did think about that, but what if the userspace code is: KNotification *n = new KNoti..

Re: Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/#review99930 --- src/knotificationmanager.cpp (line 203)