Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/ --- (Updated Oct. 13, 2016, 10:08 p.m.) Status -- This change has been

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/#review99989 --- Fix it, then Ship it! Looks good to me!

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/ --- (Updated oct. 13, 2016, 5:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread Albert Astals Cid
> On oct. 13, 2016, 5:16 p.m., David Faure wrote: > > I hope your commit log has a better description than "?" :-) The title should be good enough, the desciprtion was supposed to be two arrows pointing up, i guess something got messed up :D > On oct. 13, 2016, 5:16 p.m., David Faure wrote:

Re: Review Request 129162: Fix focus ownership if url is changed before showing the widget

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129162/#review99985 --- I hope your commit log has a better description than "?" :-)