Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Nov. 8, 2016, 1:08 p.m.) Status -- This change has been

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100629 --- Ship it! Looks ok now, except for the ATime/MTime/CTime

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 30, 2016, 10:59 p.m., David Faure wrote: > > src/k7zip.cpp, line 2499 > > > > > > Translators (and users) won't know what CTime is, but oh well, not many > > people know anyway ;) > > Romário Rios

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Nov. 1, 2016, 8:10 p.m.) Review request for KDE Frameworks.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 30, 2016, 10:59 p.m., David Faure wrote: > > src/k7zip.cpp, line 2499 > > > > > > Translators (and users) won't know what CTime is, but oh well, not many > > people know anyway ;) I'm not sure what

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100413 --- autotests/karchivetest.cpp (line 369)

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Oct. 27, 2016, 2:23 a.m.) Review request for KDE Frameworks.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Ott. 15, 2016, 7:40 p.m., Friedrich W. H. Kossebau wrote: > > Seems you are the first to add translation features to karchive. So some > > more things are needed to get translations working: > > a) adding a script which enables e.g. the bot "scripty" on the KDE i18n > > server to extract

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 15, 2016, 5:40 p.m., Friedrich W. H. Kossebau wrote: > > Seems you are the first to add translation features to karchive. So some > > more things are needed to get translations working: > > a) adding a script which enables e.g. the bot "scripty" on the KDE i18n > > server to extract

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100021 --- Seems you are the first to add translation features to

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 15, 2016, 4:05 p.m., David Faure wrote: > > src/k7zip.cpp, line 2343 > > > > > > QObject::tr() is bad practice in Qt code (the context class name is > > then "QObject" instead of e.g. K7Zip). > >

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 15, 2016, 4:05 p.m., David Faure wrote: > > src/k7zip.cpp, line 2343 > > > > > > QObject::tr() is bad practice in Qt code (the context class name is > > then "QObject" instead of e.g. K7Zip). > >

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100017 --- src/k7zip.cpp (line 2343)

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 14, 2016, 4:44 a.m., Anthony Fieroni wrote: > > Whoops, you're right. I forgot about that. - Romário --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review6

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Oct. 15, 2016, 3:08 a.m.) Review request for KDE Frameworks.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review6 --- autotests/karchivetest.cpp (line 353)

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Oct. 14, 2016, 4:29 a.m.) Review request for KDE Frameworks.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 13, 2016, 6:58 a.m., Anthony Fieroni wrote: > > > Second, i don't think library should provide strings to translate, it's an > application job. `QIODevice` provides an `errorString` method (although I don't know if it is translated) and I think other frameworks do so too, as well.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Ott. 13, 2016, 8:58 a.m., Anthony Fieroni wrote: > > src/karchive.h, line 292 > > > > > > First of all you must not provide const char interface and you must use > > i18n in all strings. > > Second, i

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review99969 --- src/karchive.h (line 292)