Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2018-02-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/#review103861 --- If this patch is not merged yet, maybe consider moving it

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2016-11-18 Thread Luke Dashjr
> On Nov. 17, 2016, 9:18 p.m., Dominik Haumann wrote: > > src/utils/document.cpp, line 97 > > > > > > Is this correct? y and x are switched, do you know any reason for this? > > Did you test? I just copied the

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2016-11-18 Thread Luke Dashjr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/ --- (Updated Nov. 18, 2016, 8:53 a.m.) Review request for Kate, KDE

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2016-11-17 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/#review100918 --- In general ok, but could you please post an updated version