Re: Windows unittests: KConfig

2022-03-21 Thread Ben Cooksley
On Mon, Mar 21, 2022 at 11:42 AM David Faure  wrote:

> On dimanche 20 mars 2022 22:13:17 CET Christoph Cullmann (cullmann.io)
> wrote:
> > On 2022-03-20 22:07, David Faure wrote:
> > > The KConfig unittests rely on DBus nowadays (for change notification).
> > > This is turned off on Android, and is a cmake option elsewhere,
> > > defaulting to ON.
> > >
> > > On Windows, I'm sure a lot of other modules rely on DBus, so I suppose
> > > it's just a matter of starting the dbus daemon for those modules that
> > > need it?
> > > Currently the kconfig tests fail for lack of dbus:
> > >
> > > 21:55:23  ERROR: The process "dbus-daemon.exe" not found.
> > >
> https://build.kde.org/job/Frameworks/view/Platform%20-%20WindowsMSVCQt5.15
> > > /job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.15/217/console
> > Hi,
> >
> > actually, if one can just disable that on Windows, I would be rather in
> > favor of that.
> > Any dbus stuff is just a pain there and at least Okular/Kate/... as
> > packaged for Windows store avoid the use of any dbus calls.
>
> Makes sense.
>
> I was thinking "akonadi needs dbus anyway", but indeed, that doesn't apply
> to
> standalone apps, and the DBus stuff in KConfig seems to be mostly for
> workspace-level notifications (color theme changed, etc.).
>
> Made a merge request to turn this off on Windows by default:
> https://invent.kde.org/frameworks/kconfig/-/merge_requests/120


If we could head in the direction of being free of D-Bus on Windows (and
Mac as well I guess) then that would definitely be preferrable.
D-Bus makes no sense on those platforms and has only been a cause of issues.

Cheers,
Ben


>
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>
>


Re: Windows unittests: KConfig

2022-03-20 Thread David Faure
On dimanche 20 mars 2022 22:13:17 CET Christoph Cullmann (cullmann.io) wrote:
> On 2022-03-20 22:07, David Faure wrote:
> > The KConfig unittests rely on DBus nowadays (for change notification).
> > This is turned off on Android, and is a cmake option elsewhere,
> > defaulting to ON.
> > 
> > On Windows, I'm sure a lot of other modules rely on DBus, so I suppose
> > it's just a matter of starting the dbus daemon for those modules that
> > need it?
> > Currently the kconfig tests fail for lack of dbus:
> > 
> > 21:55:23  ERROR: The process "dbus-daemon.exe" not found.
> > https://build.kde.org/job/Frameworks/view/Platform%20-%20WindowsMSVCQt5.15
> > /job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.15/217/console
> Hi,
> 
> actually, if one can just disable that on Windows, I would be rather in
> favor of that.
> Any dbus stuff is just a pain there and at least Okular/Kate/... as
> packaged for Windows store avoid the use of any dbus calls.

Makes sense.

I was thinking "akonadi needs dbus anyway", but indeed, that doesn't apply to 
standalone apps, and the DBus stuff in KConfig seems to be mostly for 
workspace-level notifications (color theme changed, etc.).

Made a merge request to turn this off on Windows by default:
https://invent.kde.org/frameworks/kconfig/-/merge_requests/120

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5