Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44384 --- This review has been submitted with commit 12a3023c7134afd957e39886363294d04e3cfe88 by Aleix Pol to branch frameworks. - Commit Hook On Nov. 22, 2013, 6:23 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 6:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 25, 2013, 12:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44216 --- Ok, we checked with David. Solution is to simply remove KMimeTypeResolver. Turns out it's used by nobody! So no need to install defaultviewadapter_p.h - Kevin Ottens On Nov. 22, 2013, 11:40 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 11:40 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 6:23 p.m.) Review request for KDE Frameworks. Changes --- Remove kmimetyperesolver.cpp so that we don't need to install defaultviewadapter_p.h. Now we're not installing any new header files. \o/ Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs (updated) - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44238 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 6:23 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 6:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 tier3/kio/src/filewidgets/kfiletreeview.cpp tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 tier3/kio/tests/CMakeLists.txt 7086285 tier3/kio/tests/kfiletreeviewtest.h tier3/kio/tests/kfiletreeviewtest.cpp tier4/kde4support/src/CMakeLists.txt 9a731fd tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd tier4/kde4support/tests/CMakeLists.txt 7705381 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44135 --- Don't we have better solutions than installing random private headers? Gives me an uneasy feeling. - Kevin Ottens On Nov. 21, 2013, 4:23 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 21, 2013, 4:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114003: Install private headers needed by kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp Diffs - tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 Diff: http://git.reviewboard.kde.org/r/114003/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
