Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + env. This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 12:52 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated description. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description (updated) --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
On Lug. 6, 2014, 12:57 p.m., David Faure wrote: GenericDataLocation + env is polluting the global namespace. Imagine if gnome did the same... My suggestion is GenericConfigLocation + /startkde/env/ or GenericConfigLocation + /kde-workspace/env/. Yes, this means adjusting the KCM as well, of course. I know we're in deep bikeshedding territory. ;) But perhaps plasma-workspace, given that's what's using it? On Lug. 6, 2014, 12:57 p.m., David Faure wrote: startkde/startkde.cmake, line 198 https://git.reviewboard.kde.org/r/119145/diff/1/?file=287769#file287769line198 concatenation doesn't really need sed. Right, I kept it out of laziness. ;) I'll fix. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61694 --- On Lug. 6, 2014, 12:52 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 12:52 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:13 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated diff, resolved issues, moved to GenericConfigLocation + plasma-workspace + [env|shutdown] Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Whoops, use ConfigLocation (there's no such thing as GenericConfigLocation) and update libpath to be scriptpath so that it's clear what it does. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description (updated) --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). - David Faure On July 6, 2014, 1:19 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
On July 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). I mean we should be using it once we can depend on Qt 5.4 :) For now ConfigLocation will do. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On July 6, 2014, 1:19 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
On Lug. 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). David Faure wrote: I mean we should be using it once we can depend on Qt 5.4 :) For now ConfigLocation will do. I'll add a TODO so that it is not forgotten. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On Lug. 6, 2014, 1:19 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Add a TODO. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
On July 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). David Faure wrote: I mean we should be using it once we can depend on Qt 5.4 :) For now ConfigLocation will do. Luca Beltrame wrote: I'll add a TODO so that it is not forgotten. For reference: https://codereview.qt-project.org/89209 for adding GenericConfigLocation to qtpaths. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On July 6, 2014, 1:35 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
On Lug. 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). David Faure wrote: I mean we should be using it once we can depend on Qt 5.4 :) For now ConfigLocation will do. Luca Beltrame wrote: I'll add a TODO so that it is not forgotten. David Faure wrote: For reference: https://codereview.qt-project.org/89209 for adding GenericConfigLocation to qtpaths. Done. Waiting for objections / Ship it! on this one too, so that I can commit both. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On Lug. 6, 2014, 1:35 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61708 --- startkde/startkde.cmake https://git.reviewboard.kde.org/r/119145/#comment42946 comment needs to be updated startkde/startkde.cmake https://git.reviewboard.kde.org/r/119145/#comment42945 comment needs to be updated - David Faure On July 6, 2014, 1:35 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:44 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated comments in the code. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:46 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Fixed wrong name in the comment (plasma-desktop instead of plasma-workspace). Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61724 --- Ship it! You can push it after the two fixes below. startkde/startkde.cmake https://git.reviewboard.kde.org/r/119145/#comment42949 ~/.config, rather. (technically XDG_CONFIG_HOME, but ok, no need to be exhaustive). In fact the i.e. should be e.g. or for instance / for example. startkde/startkde.cmake https://git.reviewboard.kde.org/r/119145/#comment42950 s/Move to/Use/ - we don't have to move any files :-) - David Faure On July 6, 2014, 1:46 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 1:46 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 2:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + plasma-workspace + env (or shutdown). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
