Re: Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-10-09 Thread Arjun AK

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120387/
---

(Updated Oct. 9, 2014, 4:30 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwallet


Description
---

If `walletListDirty()` is not emitted, kwalletmanager would continue to show 
the wallets even though it doesnt exist on the disk. These would be removed 
from the list only when the wallet is closed. If the user had added any new 
data to the wallets, it would be lost


Diffs
-

  src/runtime/kwalletd/kwalletd.cpp 4eb8381 

Diff: https://git.reviewboard.kde.org/r/120387/diff/


Testing
---


Thanks,

Arjun AK

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-10-07 Thread Valentin Rusu

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120387/#review68063
---

Ship it!


Ship It!

- Valentin Rusu


On Sept. 27, 2014, 11:44 a.m., Arjun AK wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120387/
 ---
 
 (Updated Sept. 27, 2014, 11:44 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kwallet
 
 
 Description
 ---
 
 If `walletListDirty()` is not emitted, kwalletmanager would continue to show 
 the wallets even though it doesnt exist on the disk. These would be removed 
 from the list only when the wallet is closed. If the user had added any new 
 data to the wallets, it would be lost
 
 
 Diffs
 -
 
   src/runtime/kwalletd/kwalletd.cpp 4eb8381 
 
 Diff: https://git.reviewboard.kde.org/r/120387/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Arjun AK
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-09-27 Thread Arjun AK

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120387/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

If `walletListDirty()` is not emitted, kwalletmanager would continue to show 
the wallets even though it doesnt exist on the disk. These would be removed 
from the list only when the wallet is closed. If the user had added any new 
data to the wallets, it would be lost


Diffs
-

  src/runtime/kwalletd/kwalletd.cpp 4eb8381 

Diff: https://git.reviewboard.kde.org/r/120387/diff/


Testing
---


Thanks,

Arjun AK

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel