Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-10 Thread Lukáš Tinkl
On Bře. 5, 2015, 4:44 odp., Lukáš Tinkl wrote: For posterity, does this still work with khotkeys? Martin Gräßlin wrote: why should it not work with khotkeys? Or better said: what should be so special about khotkeys? Nothing in particular, I was just wondering - Lukáš

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated March 10, 2015, 9:21 p.m.) Status -- This change has been

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-05 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review77063 --- For posterity, does this still work with khotkeys? - Lukáš

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-05 Thread Martin Gräßlin
On March 5, 2015, 4:44 p.m., Lukáš Tinkl wrote: For posterity, does this still work with khotkeys? why should it not work with khotkeys? Or better said: what should be so special about khotkeys? - Martin --- This is an

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76860 --- Ship it! It's looking fine, assuming the auto tests still

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76686 --- Ping, Frameworks people? - Kai Uwe Broulik On Feb. 16,

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76687 --- src/kglobalaccel.h

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 26, 2015, 9:39 nachm.) Review request for KDE Frameworks,

Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76117 --- src/kglobalaccel.cpp

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76116 --- we should investigate whether the argument for using a widget

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 16, 2015, 11:56 vorm.) Review request for KDE Frameworks,