Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-07-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/ --- (Updated July 15, 2015, 3:27 p.m.) Status -- This change has been

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-07-15 Thread Rohan Garg
On July 15, 2015, 8:49 p.m., Rohan Garg wrote: Ship It! Compiles fine on my board, tests run fine too. - Rohan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review82543

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-07-15 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review82543 --- Ship it! Ship It! - Rohan Garg On June 22, 2015, 10:43

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review81662 --- Rohan, can you test it on the offended platform? (compile and

Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/ --- Review request for KDE Frameworks and Rohan Garg. Repository:

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review81689 --- Ship it! I'd prefer `unsigned long` to `unsigned long int`