---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128831/
---
(Updated Sept. 4, 2016, 11:20 nachm.)
Review request for KDE Frameworks.
Changes
---
Tested that an enabled kwallet still works in drkonqi
Bugs: 358260
https://bugs.kde.org/show_bug.cgi?id=358260
Repository: kwallet
Description
---
If the wallet is disabled, walletlauncher() fails and
walletLauncher()->getInterface().isOpen(name) causes a crash.
This affects e.g. drkonqi, but probably also other applications.
Return false in this case, if the wallet is disabled it cannot be open either.
Diffs
-
src/api/KWallet/kwallet.cpp dffebda
Diff: https://git.reviewboard.kde.org/r/128831/diff/
Testing (updated)
---
- disable kwallet in the settings
- start a KF5 application (say, dolphin)
- make it crash, e.g. via "killall -ILL dolphin"
- try to report the crash with drkonqi
When you get to the page where you have to enter the bugzilla
username/password, drkonqi crashed, with this patch it doesn't crash.
drkonqi is also still able to get the username/password from kwallet if it is
enabled.
Thanks,
Wolfgang Bauer
