Re: Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Harald Sitter
> On Sept. 15, 2016, 8:55 a.m., Elvis Angelaccio wrote: > > I was surprised that we allow filenames with newlines in the first place. > > Shouldn't we use a server-side hook that prevents commits with broken > > filenames? Or this is only a problem with icons? It may well be that we should

Re: Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/#review99187 --- I was surprised that we allow filenames with newlines in the

Re: Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- (Updated Sept. 15, 2016, 8:17 a.m.) Status -- This change has been

Re: Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/#review99184 --- Ship it! Ship It! - Martin Gräßlin On Sept. 15, 2016,

Re: Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- (Updated Sept. 15, 2016, 8:10 a.m.) Review request for KDE Frameworks.

Review Request 128913: add a test to prevent file names from having newlines

2016-09-15 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- Review request for KDE Frameworks. Repository: breeze-icons